Skip to content

Conversation

@Bot-Enigma-0
Copy link
Contributor

@Bot-Enigma-0 Bot-Enigma-0 commented Jun 25, 2025

Proposed Changes

Give a brief overview of your contribution here in a few sentences.
The results of #2508, showed good improvement in the convergence when discretising using the product rule. Attempting same discretisation for the SST model's cross-diffusion term. An under-relaxation factor is also introduced, this helped stabilise the convergence in some testcases.

Related Work

Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@Bot-Enigma-0 Bot-Enigma-0 marked this pull request as draft June 25, 2025 16:34
/*--- Cross diffusion ---*/

Residual[1] += (1.0 - F1_i) * CDkw_i * Volume;
// Residual[1] += (1.0 - F1_i) * CDkw_i * Volume;

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant